Expose ports #239
Open
Expose ports #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belanoa
requested review from
colluca,
fischeti,
viv-eth and
paulsc96
as code owners
colluca
reviewed
May 30, 2025
There was a problem hiding this comment.
I left a few questions below.
For the rest it looks good to me. Thanks for the contribution :)
We need to do two final things to get the PR ready:
- rebase on the latest
main, once we have finished merging the multicast PR (process started, currently the commit is staged in thedevelopbranch) - merge the
riscv-opcodesbranch you have into thesnitchbranch.
colluca
force-pushed
the
ext_ports
branch
4 times, most recently
from
9a05670 to
077ba39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to expose a narrow AXI master port and a wide TCDM port. This is useful if one wants to improve the cluster's capabilities with accelerators.